Skip to content

Conversation

@MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented Apr 9, 2025

Related to dotnet/source-build#5034

Setting SetUpSourceBuildIntermediateNupkgCache=false will disable the intermediate restoration and setting
ReportPrebuiltUsage=false will disable the prebuilt validation. Both will be necessary to set during the flat flow enablement.

SetUpSourceBuildIntermediateNupkgCache was previously unused so I repurposed it.

@MichaelSimons MichaelSimons requested a review from a team as a code owner April 9, 2025 21:29
@MichaelSimons MichaelSimons requested a review from mmitche April 9, 2025 21:30
mthalman
mthalman previously approved these changes Apr 10, 2025
Co-authored-by: Matt Thalman <mthalman@microsoft.com>

<Import Project="SourceBuild/SourceBuildArcadeTools.targets" Condition="'$(DotNetBuildRepo)' == 'true' or
'$(SetUpSourceBuildIntermediateNupkgCache)' == 'true'" />
<Import Project="SourceBuild/SourceBuildArcadeTools.targets" Condition="'$(DotNetBuildRepo)' == 'true'" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For targets in SourceBuild/SourceBuildArcadeTools.targets to run, SetUpSourceBuildIntermediateNupkgCache should not be false. Would it make sense to skip this import in that case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided against it. This is going away shortly all together once the flat flow is stabilized. The existing implementation felt odd in the sense that the import still happened in many scenarios where the targets were conditioned out.

@MichaelSimons MichaelSimons merged commit 518a372 into dotnet:main Apr 10, 2025
11 checks passed
@MichaelSimons MichaelSimons deleted the disable-prebuilt-checking branch April 10, 2025 19:28
@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 23, 2025

@MichaelSimons does this need to be backported to release/9.0 for repositories that use the 9.0 Arcade SDK? cc @premun @akoeplinger

@MichaelSimons
Copy link
Member Author

No, we do not want to disable prebuilt detection for repos flowing into 9.0.

@ViktorHofer
Copy link
Member

Right. How should we handle repositories that use 9.0 Arcade but consume 10.0 SB intermediate packages? Example: https://github.com/dotnet/razor/blob/4ed93db9c39d970197c3410f9e878caaf8a92316/eng/Version.Details.xml#L8-L13

@MichaelSimons
Copy link
Member Author

I see this commit is from main. Will main flow into a 9.0 sdk feature band? If so it really should be on a 9.0 SBRP version. If it doesn't flow to 9.0, then why isn't it on 10.0 arcade?

I have no specific concern with backporting this, but we should not be disabling prebuilt detection on repos flowing into 9.0. Aside from disabling prebuilt detection, this will cause a ripple effect on other 9.0 repos that depend on it's intermediates.

@MichaelSimons
Copy link
Member Author

SBRP 10.0 with a 9.0 Arcade seems to be a pattern:

Discussed offline. Those are incorrect and should be on 9.0. @ViktorHofer is updating the subscriptions.

@ViktorHofer
Copy link
Member

OK only those three repos - puuuh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants