[release/10.0] Enhance logging for file extraction and repackaging with matching permissions #16271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Nov 5, 2025
Member
Author
|
/backport to main |
Contributor
|
Started backporting to |
2 tasks
This was referenced Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing de-dupe of signing files, when a file is first found in a container with different permissions from other entries or where permissions aren't preserved by the format. When repackaging pkg, use the one that's in the container itself. This didn't affect tarballs since the stream contents are replaced, but the entry is preserved (on macOS). A better way to do this for future archival patterns is to append this data to the ZipPart and not to the ZipData, as the latter is the cached entry and not the part representing the data in the original archive.