Fixed some minor problems for the diagnostic team's repos. #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
approved these changes
Feb 4, 2019
tmat
reviewed
Feb 4, 2019
eng/common/tools.ps1
Outdated
| & $installScript -Version $version -InstallDir $dotnetRoot | ||
| } | ||
| else { | ||
| & $installScript -Version $version -InstallDir $dotnetRoot -Architecture $architecture |
There was a problem hiding this comment.
I think we can simplify:
$archArg = if ($architecture) { $architecture } else { "<auto>" }
& $installScript -Version $version -InstallDir $dotnetRoot -Architecture $archArg`
Add optional architecture parameter to InstallDotNetSdk.
mikem8361
force-pushed
the
diagnostics
branch
from
1006811 to
cbe1693
Compare
|
Thanks guys for working this out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional architecture parameter to InstallDotNetSdk.
Trying this again with just what @tmat suggested.