Replace MonoToolArgs with TestRuntimeAdditionalArguments #2054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@chsienki I'm wondering... should we pass |
Member
|
@tmat I hadn't updated Roslyn yet, so no worries, I'll do so when this makes it into the rolsyn repo. The mono folks seemed to think it was fairly harmless to always pass --debug, but it does make it slightly slower. Given that we've got the flag now to to let arcade consumers do so, maybe lets keep it off for now, and we can re-consider if we find lots of people needing to set it. |
This was referenced Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
TestRuntimeAdditionalArgumentsproperty that allows to specify additional command line arguments passed to the test runtime (i.e.dotnetormono). Applicable only whenTestRuntimeisCoreorMono.Replaces
MonoToolArgs.