Use Microsoft copyright #2635
Merged
Use Microsoft copyright #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTortugo
approved these changes
Apr 29, 2019
| private static bool? IsMicrosoftLibrary(string copyright) | ||
| => copyright.Contains("Microsoft") ? true : copyright.Contains(".NET Foundation") ? null : (bool?)false; | ||
| private static bool IsMicrosoftLibrary(string copyright) | ||
| => copyright.Contains("Microsoft"); |
There was a problem hiding this comment.
Can't we do a full comparison with the copyright here?
There was a problem hiding this comment.
We can, but I think checking for Microsoft is sufficient.
There was a problem hiding this comment.
Given that NuGet requries letter-by-letter compliance it might be worthwhile actually doing that so we catch violations earlier.
| Override any other value the project may set. | ||
| --> | ||
| <PropertyGroup> | ||
| <Copyright>$(CopyrightMicrosoft)</Copyright> |
There was a problem hiding this comment.
Do we need to change this (https://github.com/dotnet/arcade/blob/master/Directory.Build.props#L6) as well or exclude it?
There was a problem hiding this comment.
This will override anything the repository sets. We can then stop setting it.
brettfo
added a commit
to dotnet/fsharp
that referenced
this pull request
May 6, 2019
Remove copyright made redundant by dotnet/arcade#2635.
KevinRansom
pushed a commit
to dotnet/fsharp
that referenced
this pull request
May 7, 2019
Remove copyright made redundant by dotnet/arcade#2635.
baronfel
pushed a commit
to baronfel/FSharp.Compiler.Service
that referenced
this pull request
May 26, 2019
Remove copyright made redundant by dotnet/arcade#2635.
baronfel
pushed a commit
to baronfel/FSharp.Compiler.Service
that referenced
this pull request
May 26, 2019
Remove copyright made redundant by dotnet/arcade#2635.
StephenBonikowsky
added a commit
to StephenBonikowsky/wcf
that referenced
this pull request
Jun 3, 2019
* Remove copyright made redundant by dotnet/arcade#2635.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.