Support VS single evaluation mode #5293
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent change to support RestoreUseStaticGraphEvaluation, the hook point before Restore was removed as it was assumed that the TargetFrameworks modification can be done during evaluation. As VS shares the same evaluation for restore and build, the modification is ignored (as it is conditioned on MSBuildRestoreSessionId and IsGraphBuild). Changing the condition to only check for MSBuildRestoreSessionId or building inside Visual Studio (as VS doesn't set MSBuildRestoreSessionId).
|
As an additional note, VS doesn't use static graph restore as it gets the evaluation from the project system. |
|
Closing as this doesn't fix the actual issue as restore inside VS doesn't run any targets. Following up offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent change to support RestoreUseStaticGraphEvaluation, the hook point before Restore was removed as it was assumed that the TargetFrameworks modification can be done during evaluation. As VS shares the same evaluation for restore and build, the modification is ignored (as it is conditioned on MSBuildRestoreSessionId and IsGraphBuild). Changing the condition to only check for
MSBuildRestoreSessionIdorBuildingInsideVisualStudio(as VS doesn't set MSBuildRestoreSessionId).Additionally adding a condition to
AttachTargetFrameworkSuffixToTargetFrameworksto only run if necessary.