Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add illumos setup to build-rootfs.sh #5584

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Add illumos setup to build-rootfs.sh #5584

merged 2 commits into from
Jun 2, 2020

Conversation

am11
Copy link
Member

@am11 am11 commented May 29, 2020

  • install official illumos sysroot and packages
  • build binutils and gcc with x86_64-illumos- prefix and install in $__RootfsDir
  • install some headers for libraries
  • find x86_64-illumos-gcc in $__RootfsDir
  • separate illumos and solaris in test discovery

Contributes to: dotnet/runtime#34944.

@am11
Copy link
Member Author

am11 commented May 29, 2020

cc @janvorli, please take a look.

eng/common/cross/build-rootfs.sh illumos x64
(in Europe, we can make it use German mirror by adding --use-mirror option in above command for faster package download)

it takes ~5 minutes to prepare illumos rootfs. Tested coreclr, installer and libraries native builds. I will create a separate PR in runtime repo to enable cross-compilation on illumos.

@am11
Copy link
Member Author

am11 commented May 29, 2020

Also, script does not require sudo for illumos, everything remain contained inside the $__RootfsDir.

set(${var} ${EXEC_LOCATION_${exec}} PARENT_SCOPE)
endfunction()

set(CMAKE_SYSTEM_PREFIX_PATH "${CROSS_ROOTFS}")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line tells cmake to search within the $__RootfsDir directory.

@am11
Copy link
Member Author

am11 commented Jun 2, 2020

@janvorli, @jclulow, could you please give it a pass? I will send a PR for runtime repository changes part subsequently. Thanks.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit dd717e1 into dotnet:master Jun 2, 2020
@am11 am11 deleted the feature/illumos-rootfs branch June 2, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants