Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dotnet_cli_home to repo root instead of relying in azdo variables … #5805

Merged
1 commit merged into from
Jul 17, 2020

Conversation

riarenas
Copy link
Member

…to fix local build and docker scenarios

Validated with this build that was previously failing: https://dev.azure.com/dnceng/internal/_build/results?buildId=735315&view=results

Better fix for #5402

Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

@riarenas riarenas added the auto-merge Automatically merge PR once CI passes. label Jul 17, 2020
@ghost
Copy link

ghost commented Jul 17, 2020

Hello @riarenas!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 04a4104 into dotnet:master Jul 17, 2020
MattGal added a commit to MattGal/arcade that referenced this pull request Jul 20, 2020
…riables to fix local build and docker scenarios (dotnet#5805)"

This reverts commit 04a4104.
MattGal added a commit that referenced this pull request Jul 20, 2020
…riables to fix local build and docker scenarios (#5805)" (#5815)

This reverts commit 04a4104.
@riarenas riarenas deleted the riarenas/fix-dotnet-cli-home branch January 13, 2021 20:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge PR once CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants