Set RollForward=Major for test projects

[dagood]

This lets them run locally without manually installing extra runtimes. #6126

I still get some different test failures locally after doing this, but I'm curious if the RollForward change will break PR validation in some other way.

[riarenas]

Thanks Davis for looking into it. I wonder if adding the 2.1 runtime to the global.json so that arcade installs it during the build might be a narrower fix?https://github.com/dotnet/arcade/blob/cad8f9fea5cc39501144890ab37d187d3adbdcdf/Documentation/ArcadeSdk.md#example-restoring-multiple-net-core-runtimes-for-running-tests

[dagood]

It's a different fix, and maybe more along the lines of what the infra expects. It's true that technically by running on a newer runtime, the tests could depend on some behavior that only works in the new runtime. It's also potentially odd, though, that we're testing (only?) against an old runtime even though the build tasks will be running against the newer runtime in everyone's repos. I don't really have expertise here, up to you if this is something dotnet/arcade should support and how.

[alexperovich]

The tests run with --roll-forward Major in helix, so I think this change is better because it makes the behavior the same in both places. I also agree that we should be testing on the newer runtime because all the tasks run on the newer runtime.

[ViktorHofer]

Why not instead apply a rollforward policy in global.json that is repo wide like we do in dotnet/runtime?

[dagood]

That sounds fine to me, too. Didn't know you could do it that way.

[ViktorHofer]

Cool. Yes, I would prefer the global.json setting over the msbuild property.

[jonfortescue]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ChadNedzlek]

So this is over a year old. Are we still working on this, or can it be closed?

[dagood]

Are we still working on this, or can it be closed?

I'm not. (If anyone wants to pick it up, note that #6126 is more broadly about tests not working locally on Linux, not just the runtime expectation.)