Add local build infra for arcade-powered source-build (stage 1) #6837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcade has a special version prop for CodeAnalysis.CSharp in GenFacades to try to match the version loaded by msbuild. In the offline build, this is simply the source-built version.
Microsoft.CodeAnalysis.CSharp brings in System.Collections.Immutable and System.Reflection.Metadata dependencies with prebuilt versions. We can override them to the version that we built. dotnet/arcade already defines SystemCollectionsImmutableVersion and SystemReflectionMetadataVersion, and it seems safe to use their values. See dotnet/source-build#1881
dseefeld
approved these changes
Jan 22, 2021
crummel
approved these changes
Jan 22, 2021
akoeplinger
pushed a commit
to akoeplinger/arcade
that referenced
this pull request
Apr 12, 2021
…et#6837) * Initial source-build config * Exclude unneeded project. * Reassign MsbuildTaskMicrosoftCodeAnalysisCSharpVersion in offline build Arcade has a special version prop for CodeAnalysis.CSharp in GenFacades to try to match the version loaded by msbuild. In the offline build, this is simply the source-built version. * Disable ILRewrite step - this isn't built in source-build so it fails. * Override Microsoft.CodeAnalysis.CSharp pkg deps Microsoft.CodeAnalysis.CSharp brings in System.Collections.Immutable and System.Reflection.Metadata dependencies with prebuilt versions. We can override them to the version that we built. dotnet/arcade already defines SystemCollectionsImmutableVersion and SystemReflectionMetadataVersion, and it seems safe to use their values. See dotnet/source-build#1881 Co-authored-by: Chris Rummel <crummel@microsoft.com> Co-authored-by: dseefeld <dseefeld@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/implementation-plan.md
Incorporates some simple patches and adds a
.patchfile for the changes to build arcade targetingnet5.0. Incorporation into the repo will probably involve making a centralized property for "target SDK framework version" and changing it tonet6.0. Including the patch file as it exists for 5.0 for now./cc @markwilkie