Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Add support for additional DotNetRuntime (#7158) #7382

Merged

Conversation

riarenas
Copy link
Member

Description

#7378

Cherry-pick of b61eaae to mitigate SSL issues when trying to download the install scripts.

Customer Impact

Without this change, ASPNetCore's servicing builds are having a high rate of failure during the script downloads

Regression

No

Risk

How risky is this change?

Low

Workarounds

no

@riarenas riarenas changed the title Add support for additional DotNetRuntime (#7158) [release/5.0] Add support for additional DotNetRuntime (#7158) May 12, 2021
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth an experiment of adding the runtimes (without merging them) to the unit tests proj like Hao did to make sure there aren't surprises.

@riarenas
Copy link
Member Author

May be worth an experiment of adding the runtimes (without merging them) to the unit tests proj like Hao did to make sure there aren't surprises.

Yep I'm getting a test build ready.

@riarenas
Copy link
Member Author

riarenas commented May 12, 2021

Test build: https://dev.azure.com/dnceng/public/_build/results?buildId=1135039&view=results

I see in the binlogs that the added runtimes were added as correlation payloads.

image

@MattGal
Copy link
Member

MattGal commented May 12, 2021

Test build: https://dev.azure.com/dnceng/public/_build/results?buildId=1135039&view=results

I see in the binlogs that the added runtimes were added as correlation payloads.

image

Awesome, I appreciate the diligence.

@riarenas riarenas merged commit dad4f3c into dotnet:release/5.0 May 12, 2021
@riarenas riarenas deleted the riarenas/port-additional-runtimes branch May 12, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants