Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Move to latest SDK #9994

Merged
merged 2 commits into from
Aug 12, 2022
Merged

[release/6.0] Move to latest SDK #9994

merged 2 commits into from
Aug 12, 2022

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Jul 13, 2022

To double check:

@dougbu
Copy link
Member Author

dougbu commented Aug 3, 2022

Won't pass 'til release but ready

@dougbu dougbu requested a review from mmitche August 3, 2022 17:44
@mmitche
Copy link
Member

mmitche commented Aug 9, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mmitche
Copy link
Member

mmitche commented Aug 9, 2022

@MattGal I'm not seeing actual failures in the Trx test log (no failures in the tests), but Helix is reporting exit code 1 for the run...any ideas?

@MattGal
Copy link
Member

MattGal commented Aug 9, 2022

@MattGal I'm not seeing actual failures in the Trx test log (no failures in the tests), but Helix is reporting exit code 1 for the run...any ideas?

Yes there was an outage @adiaaida was commenting about in the AzDO API; if the work item finishes happily but the helix client fails to write test results to AzDO this happens. I think you can merge on red relatively safely here, or just re-run.

@dougbu
Copy link
Member Author

dougbu commented Aug 10, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dougbu
Copy link
Member Author

dougbu commented Aug 10, 2022

Looks like something real is really wrong. Last run failed about the same way as the first.

@michellemcdaniel
Copy link
Contributor

We have opened an IcM with AzDO about this. Arcade issue is here: #10358

@MattGal
Copy link
Member

MattGal commented Aug 10, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MattGal
Copy link
Member

MattGal commented Aug 10, 2022

We have opened an IcM with AzDO about this. Arcade issue is here: #10358

I think something's genuinely broken about run 1933413, so I kicked off a new pipeline run to see what happens. We can escalate the IcM if needed but it's not broken universally (yet)

@dougbu
Copy link
Member Author

dougbu commented Aug 10, 2022

It's almost nice that the problem reproduces so reliably 😦

We updated the SDK in

and didn't hit similar problems there.

@MattGal
Copy link
Member

MattGal commented Aug 10, 2022

It's almost nice that the problem reproduces so reliably 😦

We updated the SDK in

and didn't hit similar problems there.

Arcade specifically does a bunch of custom types of test reporting, though the fact this isn't showing up in main-branch Arcade runs is very confusing (they use identical fake test results and the clients are versioned external-to-arcade). The Test API team work on IDC time so I'll start a thread to try to bump up priority of the IcM I opened.

@michellemcdaniel
Copy link
Contributor

Arcade specifically does a bunch of custom types of test reporting, though the fact this isn't showing up in main-branch Arcade runs is very confusing

It's totally happening in main branch arcade. My one-pager is in arcade/main and I saw it there

@mmitche
Copy link
Member

mmitche commented Aug 11, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dougbu
Copy link
Member Author

dougbu commented Aug 12, 2022

@MattGal did you backport your #10358 workaround (#10380) to release/6.0❔ Pretty please if not done yet…

@dougbu
Copy link
Member Author

dougbu commented Aug 12, 2022

Just in case
/azp run

@dougbu
Copy link
Member Author

dougbu commented Aug 12, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MattGal
Copy link
Member

MattGal commented Aug 12, 2022

@MattGal did you backport your #10358 workaround (#10380) to release/6.0❔ Pretty please if not done yet…

@joeloff added it to another PR to 6.0, but effectively yes. Supposedly this is fixed now, I'll get that verified today.

@dougbu
Copy link
Member Author

dougbu commented Aug 12, 2022

We're all set but have two Build Analysis checks, one that's failing, and I don't have rights to merge into release/6.0. Help plz

@michellemcdaniel
Copy link
Contributor

@AlitzelMendez will the .Net Helix Build Analysis go away? I'm fine checking this in.

@riarenas
Copy link
Member

Build analysis changed the app they use. However, since this PR was opened before the swap, it left a dangling failed check using the old app.

That dangling check didn't realize there were new runs. I clicked the rerun button which made the check update with the fact that the app was moved.

@riarenas riarenas merged commit 41323ec into release/6.0 Aug 12, 2022
@dougbu
Copy link
Member Author

dougbu commented Aug 12, 2022

I clicked the rerun button

Excellent e2e testing @riarenas 😁

@dougbu dougbu deleted the dougbu-patch-2 branch August 12, 2022 16:37
@riarenas
Copy link
Member

The fact that older checks posted by the old app won't be updated is something we might want to make more widely known though @AlitzelMendez @missymessa

@riarenas
Copy link
Member

Excellent e2e testing @riarenas 😁

That only worked because of the work that was deployed this week to make the re-run buttons do something for those checks, so it was a happy coincidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants