Skip to content

Conversation

hewe-saxo
Copy link
Contributor

Description

Add labels to all generated resources, updated default labels to align more with Kubernetes recommendations.

https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jul 2, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 2, 2025
@hewe-saxo
Copy link
Contributor Author

@davidfowl Is there anything else I should change to get this in?

@davidfowl davidfowl merged commit a892797 into dotnet:main Jul 12, 2025
496 of 498 checks passed
@davidfowl
Copy link
Member

Just FYI, this won't be in 9.4.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants