Move IInteractionService and related types to Aspire.Hosting namespace #10267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
Copilot finished work on behalf of
JamesNK
July 6, 2025 00:03
JamesNK
added
the
area-app-model
There was a problem hiding this comment.
Pull Request Overview
This PR moves interaction service types from the Aspire.Hosting.ApplicationModel namespace into Aspire.Hosting and updates all references accordingly.
- Files for
IInteractionService,InteractionService, and related model types are relocated and their namespaces updated. DashboardServicemappings now use fully qualified Proto namespaces to disambiguate between hosting and dashboard types.- Removed obsolete
using Aspire.Hosting.ApplicationModeldirectives and updated test code to reference the new namespace.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/Dashboard/DashboardServiceTests.cs | Updated test to use Aspire.Hosting.InteractionInput |
| src/Aspire.Hosting/VersionChecking/VersionCheckService.cs | Removed unused using Aspire.Hosting.ApplicationModel |
| src/Aspire.Hosting/Publishing/PublishingActivityProgressReporter.cs | Removed unused using Aspire.Hosting.ApplicationModel |
| src/Aspire.Hosting/InteractionService.cs | Changed namespace from Aspire.Hosting.ApplicationModel to Aspire.Hosting |
| src/Aspire.Hosting/IInteractionService.cs | Changed namespace from Aspire.Hosting.ApplicationModel to Aspire.Hosting |
| src/Aspire.Hosting/Dashboard/DashboardService.cs | Switched using static to new namespace and fully qualified Proto mappings |
JamesNK
force-pushed
the
copilot/fix-10266
branch
from
2ccfe77 to
d3f5ffb
Compare
davidfowl
approved these changes
Jul 10, 2025
|
Make sure to backport |
|
/backport to release/9.4 |
|
Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16187751253 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
IInteractionService,InteractionServiceand related types from theAspire.Hosting.ApplicationModelnamespace to theAspire.Hostingnamespace as requested in the issue.Changes Made
Moved files:
src/Aspire.Hosting/ApplicationModel/IInteractionService.cs→src/Aspire.Hosting/IInteractionService.cssrc/Aspire.Hosting/ApplicationModel/InteractionService.cs→src/Aspire.Hosting/InteractionService.csUpdated namespace declarations: Changed from
namespace Aspire.Hosting.ApplicationModeltonamespace Aspire.Hostingin both filesFixed namespace conflicts: Updated
DashboardService.csto use fully qualified names to disambiguate between the hosting types and Proto types (e.g.,Aspire.Hosting.MessageIntentvsAspire.DashboardService.Proto.V1.MessageIntent)Removed unnecessary using statements: Cleaned up files that no longer need
using Aspire.Hosting.ApplicationModelsince the types are now in the same namespaceUpdated test references: Fixed test code to reference the types in their new namespace location
Types Moved
The following types are now in the
Aspire.Hostingnamespace:IInteractionServiceInteractionServiceInteractionInputInputTypeMessageIntentInteractionResult<T>InputsDialogInteractionOptionsMessageBoxInteractionOptionsMessageBarInteractionOptionsInteractionOptionsInputsDialogValidationContextAll builds and tests pass successfully after the migration.
Fixes #10266.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.