Skip to content

Conversation

danespinosa
Copy link
Contributor

@danespinosa danespinosa commented Jul 14, 2025

updated test

Description

Updated contributing.md to specify how to test the aspire code, noting that the necessary flag to test on windows is -test not --test The screenshot below shows how --test fails with Uknown Switch vs -test that works like expected
image

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings July 14, 2025 20:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the contributing guide to use the correct test flag on Windows by replacing --test with -test.

  • Correct Windows build script invocation to use a single hyphen flag

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 14, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 14, 2025
@davidfowl davidfowl enabled auto-merge (squash) July 14, 2025 20:28
@davidfowl davidfowl merged commit 8e6a03e into dotnet:main Jul 14, 2025
274 of 275 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants