Make uninitialised parameters warnings not errors

[afscrome]

Description

• Make uninitalised parameters show up as warnings rather than errors to match the warning icon by the banner.
• Fix KnownResourceStateStyles.Warn not matching the style defined in ResourceStateViewModel (warn vs warning)

Note, last is technically a breaking change as anyone who set the style to the string "warning" instead of usign KnownResourceStyles will now have their icons show up as white dots, rather than warning triangles. This breaking change could be mitigated by adding both warn and warning to ResourceStateViewModel.cs.

Fixes #11992

After:

Before:

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Link to aspire-docs issue (consider using one of the following templates):
      • New (or update) doc-idea template
      • New breaking-change template
      • New diagnostic template
  • No

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11994

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11994"

[JamesNK]

I think error on the resource makes more sense. A resource is blocked until the error (missing params) is resolved. It's not something that you can ignore like a warning.

The different levels kind of makes sense:

• A resource is broken so has an error
• However, it is possible to use the rest of the dashboard and resources (assuming they don't have a reference to the broken resource) so the overall message bar level is a warning.

But maybe I'm over thinking it and a consistent warning icon would help people figure out the problem quicker.

@maddymontaquila @DamianEdwards @davidfowl Thoughts?

[DamianEdwards]

@JamesNK I think your logic makes sense, but I see the appeal of aligning the level too. That said, I bump more on the mismatched naming, i.e. "Unresolved parameters" vs. "Value missing". I think doing something to align those would be far more impactful than changing the warning/error level of either.

[JamesNK]

I agree. Unresolved parameter is clearer than Value missing

[davidfowl]

dashboard tests need updating?