Add ViteApp and Npm Package Manager #12283
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,12 +27,16 @@ | |
| } | ||
| }, | ||
| "angular": { | ||
| "type": "container.v1", | ||
| "build": { | ||
| "context": "../AspireJavaScript.Angular", | ||
| "dockerfile": "../AspireJavaScript.Angular/Dockerfile" | ||
| }, | ||
| "env": { | ||
| "NODE_ENV": "development", | ||
| "WEATHERAPI_HTTP": "{weatherapi.bindings.http.url}", | ||
| "services__weatherapi__http__0": "{weatherapi.bindings.http.url}", | ||
| "WEATHERAPI_HTTPS": "{weatherapi.bindings.https.url}", | ||
| "services__weatherapi__https__0": "{weatherapi.bindings.https.url}", | ||
| "PORT": "{angular.bindings.http.targetPort}" | ||
| }, | ||
|
|
@@ -47,12 +51,16 @@ | |
| } | ||
| }, | ||
| "react": { | ||
| "type": "container.v1", | ||
| "build": { | ||
| "context": "../AspireJavaScript.React", | ||
| "dockerfile": "../AspireJavaScript.React/Dockerfile" | ||
| }, | ||
| "env": { | ||
| "NODE_ENV": "development", | ||
| "WEATHERAPI_HTTP": "{weatherapi.bindings.http.url}", | ||
| "services__weatherapi__http__0": "{weatherapi.bindings.http.url}", | ||
| "WEATHERAPI_HTTPS": "{weatherapi.bindings.https.url}", | ||
| "services__weatherapi__https__0": "{weatherapi.bindings.https.url}", | ||
| "BROWSER": "none", | ||
| "PORT": "{react.bindings.http.targetPort}" | ||
|
|
@@ -68,12 +76,16 @@ | |
| } | ||
| }, | ||
| "vue": { | ||
| "type": "container.v1", | ||
| "build": { | ||
| "context": "../AspireJavaScript.Vue", | ||
| "dockerfile": "../AspireJavaScript.Vue/Dockerfile" | ||
| }, | ||
| "env": { | ||
| "NODE_ENV": "development", | ||
| "WEATHERAPI_HTTP": "{weatherapi.bindings.http.url}", | ||
| "services__weatherapi__http__0": "{weatherapi.bindings.http.url}", | ||
| "WEATHERAPI_HTTPS": "{weatherapi.bindings.https.url}", | ||
| "services__weatherapi__https__0": "{weatherapi.bindings.https.url}", | ||
| "PORT": "{vue.bindings.http.targetPort}" | ||
| }, | ||
|
|
@@ -86,6 +98,31 @@ | |
| "external": true | ||
| } | ||
| } | ||
| }, | ||
| "reactvite": { | ||
|
There was a problem hiding this comment. @vhvb1989 this is what wil break azd, we're not deploying this resource but need to build it. |
||
| "type": "container.v1", | ||
| "build": { | ||
| "context": "../AspireJavaScript.Vite", | ||
| "dockerfile": "reactvite.Dockerfile" | ||
| }, | ||
| "env": { | ||
| "NODE_ENV": "development", | ||
| "PORT": "{reactvite.bindings.http.targetPort}", | ||
| "WEATHERAPI_HTTP": "{weatherapi.bindings.http.url}", | ||
| "services__weatherapi__http__0": "{weatherapi.bindings.http.url}", | ||
| "WEATHERAPI_HTTPS": "{weatherapi.bindings.https.url}", | ||
| "services__weatherapi__https__0": "{weatherapi.bindings.https.url}", | ||
| "BROWSER": "none" | ||
| }, | ||
| "bindings": { | ||
| "http": { | ||
| "scheme": "http", | ||
| "protocol": "tcp", | ||
| "transport": "http", | ||
| "targetPort": 8003, | ||
| "external": true | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| FROM node:22-slim | ||
| WORKDIR /app | ||
| COPY . . | ||
| RUN npm install | ||
| RUN npm run build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Aspire.Hosting.ApplicationModel; | ||
|
|
||
| namespace Aspire.Hosting.NodeJs; | ||
|
|
||
| /// <summary> | ||
| /// Represents an annotation for a JavaScript installer resource. | ||
| /// </summary> | ||
| public sealed class JavaScriptPackageInstallerAnnotation(ExecutableResource installerResource) : IResourceAnnotation | ||
| { | ||
| /// <summary> | ||
| /// The instance of the Installer resource used. | ||
| /// </summary> | ||
| public ExecutableResource Resource { get; } = installerResource; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Aspire.Hosting.ApplicationModel; | ||
|
|
||
| namespace Aspire.Hosting.NodeJs; | ||
|
|
||
| /// <summary> | ||
| /// Represents the annotation for the JavaScript package manager used in a resource. | ||
| /// </summary> | ||
| /// <param name="packageManager">The name of the JavaScript package manager.</param> | ||
| public sealed class JavaScriptPackageManagerAnnotation(string packageManager) : IResourceAnnotation | ||
| { | ||
| /// <summary> | ||
| /// Gets the name of the JavaScript package manager. | ||
| /// </summary> | ||
| public string PackageManager { get; } = packageManager; | ||
|
|
||
| /// <summary> | ||
| /// Gets the command line arguments for the JavaScript package manager's install command. | ||
| /// </summary> | ||
| public string[] InstallCommandLineArgs { get; init; } = []; | ||
|
|
||
| /// <summary> | ||
| /// Gets the command line arguments for the JavaScript package manager's run command. | ||
| /// </summary> | ||
| public string[] RunCommandLineArgs { get; init; } = []; | ||
|
|
||
| /// <summary> | ||
| /// Gets a string value that separates the package manager command line args from the tool's command line args. | ||
| /// By default, this is "--". | ||
| /// </summary> | ||
| public string? CommandSeparator { get; init; } = "--"; | ||
|
|
||
| /// <summary> | ||
| /// Gets the command line arguments for the JavaScript package manager's command that produces assets for distribution. | ||
| /// </summary> | ||
| public string[] BuildCommandLineArgs { get; init; } = []; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.