Skip to content

Conversation

adamint
Copy link
Member

@adamint adamint commented Oct 23, 2025

Follows up #12285, implementing the changes requested in reviews

@Copilot Copilot AI review requested due to automatic review settings October 23, 2025 17:35
@github-actions
Copy link
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12319

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12319"

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements review feedback from #12285, focusing on code quality improvements and development experience enhancements. Key changes include refactoring environment variable references, improving logging levels, and adding better support for VS Code Insiders.

  • Introduces a centralized EnvironmentVariables enum to replace string literals for environment variable names
  • Downgrades informational logging to debug level for CLI path configuration
  • Adds support for VS Code Insiders in build scripts and improves development documentation

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
extension/src/utils/environment.ts Added EnvironmentVariables enum for centralized environment variable name management
extension/src/utils/workspace.ts Updated to use EnvironmentVariables enum instead of string literal
extension/src/utils/AspireTerminalProvider.ts Updated to use EnvironmentVariables enum and changed logging from info to debug level
extension/src/debugger/AspireDebugSession.ts Updated to use EnvironmentVariables enum instead of string literal
extension/src/commands/settings.ts New command to open extension settings in VS Code
extension/src/extension.ts Registered new settings command
extension/package.nls.json Added localization entry for settings command
extension/package.json Added settings command definition
extension/loc/xlf/aspire-vscode.xlf Added translation unit for settings command
extension/build.sh Updated to check for both VS Code and VS Code Insiders
extension/build.ps1 Updated to check for both VS Code and VS Code Insiders
extension/CONTRIBUTING.MD Enhanced documentation with CLI build instructions and debugging setup
extension/.vscode/tasks.json Added explicit labels to tasks for clarity
extension/.vscode/launch.json Updated comments and task references
.vscode/tasks.json New root-level tasks configuration with path property for extension tasks
.vscode/settings.json Disabled Aspire settings prompt for extension development
.vscode/launch.json New root-level launch configuration for extension debugging

@adamint adamint enabled auto-merge (squash) October 23, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant