Cleanup logging when we don't apply certs #12323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12323Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12323" |
There was a problem hiding this comment.
Pull Request Overview
This PR refines the logging behavior for certificate authority trust configuration in DCP executor. The main improvement is moving from unconditional warning logs to conditional, targeted logs that only fire when configuration conflicts are explicitly detected, while also providing the specific environment variable or argument name that caused the conflict.
Key Changes:
- Removed generic warning logs that fired whenever custom certificate configuration was skipped
- Added targeted warning logs that include the specific conflicting argument or environment variable name
- Added
ILoggerparameter to certificate configuration methods to enable resource-specific logging
|
Azure Pipelines successfully started running 2 pipeline(s). |
mitchdenny
approved these changes
Oct 24, 2025
radical
pushed a commit
that referenced
this pull request
Oct 29, 2025
* Cleanup logging when we don't apply certs * Respond to PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was over logging when custom certificates weren't being applied. This PR ensures we only log when we're explicitly skipping applying certificates due to conflicting configuration. Additionally, I'm logging the environment variable name or argument flag that caused us to skip the config to make it easier to troubleshoot.