Allow AzureEnvironmentResource to delegate to compute resources' build steps #12327
+138
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d steps When an individual compute resource has its own build steps, the AzureEnvironmentResource shouldn't try to build the image itself. Instead, the environment's build step should be dependent on the compute resource's build step. Contributes to dotnet#12162
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12327Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12327" |
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Azure deployment pipeline to allow individual compute resources to define their own build steps. When a compute resource has custom build steps, the AzureEnvironmentResource delegates to them instead of building the image itself. This is achieved by introducing a new pipeline configuration that establishes dependencies between the environment's build step and resource-specific build steps.
Key changes:
- Introduced a new pipeline step (
default-image-tags) that assigns default deployment tags to resources - Added pipeline configuration logic to detect compute resources with custom build steps and establish proper dependencies
- Modified the main build step to only build images for resources without custom build steps
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure/AzureEnvironmentResource.cs | Refactored build pipeline to support delegating to compute resources' custom build steps through dependency management |
| tests/Aspire.Hosting.Azure.Tests/AzureDeployerTests.cs | Added test to verify that resources with custom build steps are properly handled and dependencies are correctly configured |
captainsafia
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an individual compute resource has its own build steps, the AzureEnvironmentResource shouldn't try to build the image itself. Instead, the environment's build step should be dependent on the compute resource's build step.
Contributes to #12162
Checklist