-
Couldn't load subscription status.
- Fork 712
Add ContainerFilesDestinationAnnotation support to ProjectResource #12355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
8
commits into
main
Choose a base branch
from
copilot/enhance-project-resource-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+229
−28
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cf46c78
Initial plan
Copilot 2a8cabb
Add ContainerFilesDestinationAnnotation support to ProjectResource
Copilot e342d5d
Address PR feedback: use IContainerRuntime, fix PublishDir, generic s…
Copilot f64bdc1
Merge branch 'main' into copilot/enhance-project-resource-support
eerhardt 6719d44
Make it work in the playground
eerhardt cd9a23f
Refactor to build project image first, then layer container files via…
Copilot 1b0aa02
Revert CopyContainerFilesAsync from IContainerRuntime - no longer needed
Copilot 1272212
Make it work by using the correct image name.
eerhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 5 additions & 26 deletions
31
playground/AspireWithJavaScript/AspireJavaScript.AppHost/AppHost.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,16 @@ | ||
| var builder = DistributedApplication.CreateBuilder(args); | ||
|
|
||
| builder.AddAzureContainerAppEnvironment("env"); | ||
|
|
||
| var weatherApi = builder.AddProject<Projects.AspireJavaScript_MinimalApi>("weatherapi") | ||
| .WithExternalHttpEndpoints(); | ||
|
|
||
| builder.AddNpmApp("angular", "../AspireJavaScript.Angular") | ||
| .WithNpmPackageManager() | ||
| .WithReference(weatherApi) | ||
| .WaitFor(weatherApi) | ||
| .WithHttpEndpoint(env: "PORT") | ||
| .WithExternalHttpEndpoints() | ||
| .PublishAsDockerFile(); | ||
|
|
||
| builder.AddNpmApp("react", "../AspireJavaScript.React") | ||
| .WithNpmPackageManager() | ||
| .WithReference(weatherApi) | ||
| .WaitFor(weatherApi) | ||
| .WithEnvironment("BROWSER", "none") // Disable opening browser on npm start | ||
| .WithHttpEndpoint(env: "PORT") | ||
| .WithExternalHttpEndpoints() | ||
| .PublishAsDockerFile(); | ||
|
|
||
| builder.AddNpmApp("vue", "../AspireJavaScript.Vue") | ||
| .WithNpmPackageManager() | ||
| .WithReference(weatherApi) | ||
| .WaitFor(weatherApi) | ||
| .WithHttpEndpoint(env: "PORT") | ||
| .WithExternalHttpEndpoints() | ||
| .PublishAsDockerFile(); | ||
|
|
||
| builder.AddViteApp("reactvite", "../AspireJavaScript.Vite") | ||
| var reactvite = builder.AddViteApp("reactvite", "../AspireJavaScript.Vite") | ||
| .WithNpmPackageManager() | ||
| .WithReference(weatherApi) | ||
| .WithEnvironment("BROWSER", "none") | ||
| .WithExternalHttpEndpoints(); | ||
|
|
||
| weatherApi.PublishWithContainerFiles(reactvite, "./wwwroot"); | ||
|
|
||
| builder.Build().Run(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: UseFileServer combines these