Add 'do' command to runtime-only check #12669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12669Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12669" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the "do" command to the list of runtime-only commands that should skip template package prefetching. The do command executes specific deployment pipeline steps and, like run, publish, and deploy, does not require template package metadata during its operation.
Key Changes
- Added "do" to the list of runtime-only commands in
IsRuntimeOnlyCommand()method inNuGetPackagePrefetcher.cs
davidfowl
approved these changes
Nov 4, 2025
Member
Author
|
/backport to release/13.0 |
Contributor
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19080994292 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid doing NuGet package prefetching when the
docommand is called.Note: we're still doing the prefetch to check for CLI updates on every command (ref). We could probably avoid doing a NuGet call on every invocation to the CLI here.