Make None be the index 0 enum value for CertificateTrustScope #12673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12673Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12673" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorders the CertificateTrustScope enum values to make None the first value instead of the last. This is a breaking API change that affects the default enum value and improves the logical ordering by placing the "do nothing" option first.
Key changes:
- Moved
Noneenum value from last position to first position - Updated
Appenddocumentation to clarify it is the default mode - Maintained all existing XML documentation with appropriate updates
src/Aspire.Hosting/ApplicationModel/CertificateAuthorityCollectionAnnotation.cs
Show resolved
Hide resolved
karolz-ms
approved these changes
Nov 4, 2025
Member
Author
|
/backport to release/13.0 |
Contributor
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19080153065 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
Nonebe the index 0 value for theCertificateTrustScopeenum.