-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert http resilience upgrade #2107
Conversation
…)" This reverts commit 2bf302b. There is a breaking change with Grpc clients in this version.
This allows the Http.Resilience handlers to handle the timeout correctly.
Would it be possible to also add an explicit unit test for this, so |
What exactly do you imagine us testing? This is a break between Http.Resilience (in dotnet/extensions) and gRPC client (which we don't own). .NET Aspire doesn't do anything with gRPC by default, we just happen to use it in one of our "playground apps". |
ah, ok. nvm then! |
FWIW, the issue will be fixed in extensions for 8.2, either by fixing the code that introduced the regression or by reverting the change entirely. |
We need to fix this sooner because our playground/eShopLite app is broken in |
* Revert "Update Microsoft.Extensions.Http.Resilience to 8.2 (dotnet#2094)" This reverts commit 2bf302b. There is a breaking change with Grpc clients in this version. See dotnet/extensions#4924 * Set the EndToEnd test HttpClient timeout to infinite This allows the Http.Resilience handlers to handle the timeout correctly.
There is a breaking change with Grpc clients in this version. See dotnet/extensions#4924
Microsoft Reviewers: Open in CodeFlow