Skip to content

Conversation

@tlmii
Copy link
Member

@tlmii tlmii commented Mar 13, 2024

Fixes #2661

When clicking the ... on the bottom couple rows, it'll now go up as expected:
image

The 200 matches the default horizontal threshold.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 13, 2024
@tlmii
Copy link
Member Author

tlmii commented Mar 13, 2024

There's a flicker of vertical scrollbar as the menu repositions itself, similar to what I saw when implementing #2572. The fix isn't quite as simple though, since we do want it to be able to overflow the bottom of the grid (unlike the right edge of the grid):

ResourceCommandsBottomGlitch

The flicker is less bad than not being able to access the menu, so I think this PR should still go in. I'll file an issue once this goes in to track it. I think this (unlike the original flicker) may require going a little deeper in the layers.

@JamesNK
Copy link
Member

JamesNK commented Mar 13, 2024

Is the flicker issue something for Fluent UI to fix?

@tlmii
Copy link
Member Author

tlmii commented Mar 13, 2024

Is the flicker issue something for Fluent UI to fix?

My testing when doing the initial command support seemed to indicate that it was either an issue in fluent ui (the web components, not the blazor components) or a conflict between the two component layers. Filed #2837

@tlmii tlmii merged commit 99b034f into dotnet:main Mar 13, 2024
@tlmii tlmii deleted the dev/menu-button-overflow branch March 13, 2024 06:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resource commands menu goes off the bottom of the screen

2 participants