Skip to content

Make status column icons colorblind friendly#3401

Merged
kvenkatrajan merged 1 commit intodotnet:mainfrom
drewnoakes:consistent-status-icons
Apr 11, 2024
Merged

Make status column icons colorblind friendly#3401
kvenkatrajan merged 1 commit intodotnet:mainfrom
drewnoakes:consistent-status-icons

Conversation

@drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Apr 4, 2024

Ensures these icons are differentiated not only by colour, but also by icon.

Also fixes this issue, pointed out offline by @timheuer:

image

Microsoft Reviewers: Open in CodeFlow

Ensures these icons are differentiated not only by colour, but also by icon.
@danmoseley
Copy link
Member

do any of the 3 remaining uses of ""Icons.Filled.Size16.Circle"" in that file need to be visually distinguishable?

@drewnoakes
Copy link
Member Author

I think the featureless circle makes sense for "unknown" state, which is two of the three. The other is "starting" state. Perhaps that could be an outlined circle.

@drewnoakes
Copy link
Member Author

drewnoakes commented Apr 4, 2024

Did we ever consider using a spinner for "starting" status items?

https://www.fluentui-blazor.net/ProgressRing

@danmoseley
Copy link
Member

Looks appropriate to me, my 2c

@kvenkatrajan
Copy link
Member

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8654453546

@danmoseley
Copy link
Member

The other is "starting" state. Perhaps that could be an outlined circle.

@drewnoakes do we still need to distinguish this, to be accessible?

@drewnoakes drewnoakes deleted the consistent-status-icons branch April 15, 2024 03:25
drewnoakes added a commit to drewnoakes/aspire that referenced this pull request Apr 15, 2024
This makes the difference between 'Starting' and 'Unknown' states visually differentiable by glyph, rather than colour alone. Follows on from dotnet#3401.
@drewnoakes
Copy link
Member Author

@drewnoakes do we still need to distinguish this, to be accessible?

Yes, #3689

I decided against using a spinner, mostly because it didn't seem possible to make the Blazor Fluent UI one that small.

drewnoakes added a commit that referenced this pull request Apr 16, 2024
This makes the difference between 'Starting' and 'Unknown' states visually differentiable by glyph, rather than colour alone. Follows on from #3401.
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
This makes the difference between 'Starting' and 'Unknown' states visually differentiable by glyph, rather than colour alone. Follows on from #3401.
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants