[tests] Fix some flaky tests in Aspire.Hosting.Azure.Tests #5187
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the manifest Other tests also generate and use `postgres.module.bicep` in the tests' bindir, and these can run in parallel causing them to interfere with each other. Issue: dotnet#5174
ghost
added
the
area-integrations
Avoid interfering with other tests by generating the bicep files in per-test temporyary paths. `AzureBicepResourceTests.AsAzurePostgresFlexibleServerViaRunMode` uses `postgres.module.bicep` also, and that file can get overwritten by other tests like in `AzureBicepResourceTests`. Issue: dotnet#5113
radical
force-pushed
the
fix-manifest-tests
branch
from
f92bd77 to
4d13422
Compare
radical
added
area-app-model
sebastienros
approved these changes
Aug 5, 2024
Member
|
I was literally looking at this same problem yesterday! Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests generate
.module.bicepfiles in the tests'bindir. Some such tests running in parallel can interfere with others getting the incorrect content.postgres.module.bicep, and before it can read it back, it gets overwritten by a different test with slightly different contents, thus breaking the first test.System.IO.IOException: The process cannot access the file '/mnt/vss/_work/1/s/artifacts/bin/Aspire.Hosting.Azure.Tests/Release/net8.0/postgres.module.bicep' because it is being used by another process.Fixes: #5174
Fixes: #5113
Microsoft Reviewers: Open in CodeFlow