Skip to content

Adding public API test coverage #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 29 commits into from
Closed

Adding public API test coverage #5407

wants to merge 29 commits into from

Conversation

@Zombach
Copy link
Contributor

@Zombach Zombach commented Aug 23, 2024 •
edited
Loading

Initial issues #2649
Issues #5047
message

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

Added public API test coverage for:

  • Aspire.Pomelo.EntityFrameworkCore.MySql
  • Aspire.Qdrant.Client
  • Aspire.RabbitMQ.Client
  • Aspire.Seq
  • Aspire.StackExchange.Redis
  • Aspire.StackExchange.Redis.DistributedCaching
  • Aspire.StackExchange.Redis.OutputCaching
  • Aspire.Hosting.Oracle
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 23, 2024
@Zombach Zombach marked this pull request as draft August 23, 2024 20:58
@Zombach
Copy link
Contributor Author

Zombach commented Aug 23, 2024

@Alirexaa Hello, this is for the next group

@Zombach
Copy link
Contributor Author

Zombach commented Aug 23, 2024

Aspire.Pomelo.EntityFrameworkCore.MySql

@Zombach Zombach mentioned this pull request Aug 23, 2024
Closed
56 tasks
@Zombach
Copy link
Contributor Author

Zombach commented Aug 24, 2024

Aspire.Qdrant.Client
Aspire.RabbitMQ.Client
Aspire.Seq

@Zombach
Copy link
Contributor Author

Zombach commented Aug 24, 2024 •
edited
Loading

Aspire.StackExchange.Redis
Aspire.StackExchange.Redis.DistributedCaching
Aspire.StackExchange.Redis.OutputCaching
Aspire.Hosting.Oracle

Zombach and others added 3 commits August 24, 2024 22:14
@Zombach
Aspire.StackExchange.Redis
218deb1 
Aspire.StackExchange.Redis.DistributedCaching
Aspire.StackExchange.Redis.OutputCaching
@Zombach
Merge branch 'dotnet:main' into validate-arguments-of-public-methods#…
f22026e 
…part-3
@Zombach
Aspire.Hosting.Oracle
023da20
@Zombach Zombach marked this pull request as ready for review August 25, 2024 10:00
@Zombach Zombach changed the title Adding public API test coverage(DRAFT) Adding public API test coverage Aug 27, 2024
@build-analysis build-analysis bot mentioned this pull request Sep 20, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Sep 25, 2024
Closed
3 tasks
@build-analysis build-analysis bot mentioned this pull request Oct 24, 2024
Closed
@danmoseley
Copy link
Member

danmoseley commented Feb 2, 2025

@Zombach resolved a minor conflict. Is this ready for review?

I imagine it's incomplete given updates to the public API, but IMO, even if it's partial (but all accurate) it's likely worth review and merging as it's large.

@danmoseley danmoseley added the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 2, 2025
@Zombach Zombach closed this Feb 12, 2025
@Zombach Zombach mentioned this pull request Feb 12, 2025
Closed
19 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical Awaiting requested review from radical radical is a code owner

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

@sebastienros sebastienros Awaiting requested review from sebastienros sebastienros is a code owner

Assignees

No one assigned

Labels

area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zombach @danmoseley