Skip to content

Allow Dashboard application to roll-forward #5540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Allow Dashboard application to roll-forward #5540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Aspire.Dashboard/Aspire.Dashboard.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@
CS8002: Referenced assembly does not have a strong name
-->
<NoWarn>$(NoWarn);CS1591;CS8002</NoWarn>

<!-- This Application is a framework-dependent application that targets .NET 8.0. This means that the
application is not able to run if the place where it is deployed does not have the .NET 8.0 runtime installed.
Given we want to be able to support people running on environments where they only have the 9.0 SDK/runtime installed,
we allow roll-forward to the next major in order to support these customers.-->
<RollForward>Major</RollForward>
Copy link
Member

@eerhardt eerhardt Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we going to test this?

Copy link
Member Author

@joperezr joperezr Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote in the description, the plan is that once we add 9.0 templates (@radical is working on it) we'll be adding tests specifically for environments with only 9.0 SDK installed (to validate that 9.0 templates can be created and built), so at that time we'll be able to add a test for this by using the 9.0 SDK to create a template, run it, and then validate that the dashboard is loading correctly.

Copy link
Member

@eerhardt eerhardt Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to run the Dashboard tests on net9? "validate that the dashboard is loading correctly" is a good first step, but it won't cover all the use cases of the dashboard.

Copy link
Member Author

@joperezr joperezr Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can certainly consider it, but not sure if we would get a lot from it so perhaps we can consider doing it in a format similar to runtime's outerloop runs (run once a day maybe?). Point being those tests would mostly be trying to catch breaking changes between 8.0 and 9.0, which while they are very possible, I'm guessing it is not something that may add a lot of value on testing on each CI run.

Copy link
Member Author

@joperezr joperezr Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My above suggestion for "is it loading correctly" was simply to validate that the property is doing it's job and the 9.0 runtime is effectively being able to run the dashboard to begin with.

</PropertyGroup>

<PropertyGroup>
Expand Down