Skip to content

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Sep 9, 2024

Description

Follow-up to #5418.

Add support for ServiceBus references to Azure Functions projects by implementing the IResourceWithAzureFunctionsConfig interface on the AzureServiceBusResource.

Added tests and validating locally. Tests for this scenario are exempt from CI since Azure Service Bus requires access to provisioning in CI.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes -- tests only run locally, require Service Bus provisioning
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 9, 2024
@captainsafia captainsafia added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication azure-functions Issues related to the Azure Functions integration and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 9, 2024
@davidfowl davidfowl merged commit 22eae0d into main Sep 9, 2024
@davidfowl davidfowl deleted the safia/azfunc-service-bus branch September 9, 2024 05:25
@davidfowl
Copy link
Member

Tested locally.

@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Sep 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure azure-functions Issues related to the Azure Functions integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants