Skip to content

WaitFor for MongoDB (health checks) #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

WaitFor for MongoDB (health checks) #5697

merged 1 commit into from
Sep 13, 2024

Conversation

@mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 13, 2024 •
edited by dotnet-policy-service bot
Loading

Description

Wires up health checks to the AddMongoDB(...) so that it can work fully with WaitFor.

Related #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 13, 2024
@mitchdenny mitchdenny mentioned this pull request Sep 13, 2024
Closed
15 tasks
@build-analysis build-analysis bot mentioned this pull request Sep 13, 2024
Closed
@mitchdenny
Copy link
Member Author

mitchdenny commented Sep 13, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 13, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Sep 13, 2024
Open
3 tasks
@davidfowl
Copy link
Member

davidfowl commented Sep 13, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 13, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Sep 13, 2024
Closed
@mitchdenny
Copy link
Member Author

mitchdenny commented Sep 13, 2024

Waiting on #5701

@mitchdenny
Copy link
Member Author

mitchdenny commented Sep 13, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 13, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl davidfowl merged commit e50ff7a into main Sep 13, 2024
@davidfowl davidfowl deleted the mitchdenny/waitfor-mongodb branch September 13, 2024 11:29
@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages mongodb Issues related to mongodb integrations and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Sep 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidfowl davidfowl davidfowl approved these changes

Assignees

No one assigned

Labels

area-integrations Issues pertaining to Aspire Integrations packages mongodb Issues related to mongodb integrations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mitchdenny @davidfowl