Skip to content

Conversation

@mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 23, 2024

Description

This PR introduces some changes related to WaitFor. Here is the high-level summary:

  1. WaitFor and WaitForCompletion add a new annotation to the resource which captures whether to wait for completion or just until healthy.
  2. When the DAB creates the app host it wires up to the BeforeResourceStartedEvent which calls out to RNS to wait for the resource dependencies.

Fixes #5557 #5558

image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No (existing test coverage is adequate)
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • [x No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@mitchdenny
Copy link
Member Author

/cc @afscrome

@mitchdenny mitchdenny self-assigned this Sep 23, 2024
@mitchdenny mitchdenny added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 23, 2024
@mitchdenny mitchdenny added this to the 9.0 milestone Sep 23, 2024
@mitchdenny mitchdenny marked this pull request as ready for review September 23, 2024 07:26
Copy link
Contributor

@afscrome afscrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change.

@mitchdenny mitchdenny changed the title WaitAnnotation and IDistributedApplicationOrchestrator WaitAnnotation and ResourceNotificationService.WaitForDependenciesAsync Sep 23, 2024
@mitchdenny mitchdenny merged commit 570db52 into main Sep 23, 2024
@mitchdenny mitchdenny deleted the mitchdenny/waitannotation-and-orchestrator branch September 23, 2024 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hard to see what WaitFor is really waiting on

4 participants