-
Notifications
You must be signed in to change notification settings - Fork 727
Add WithHttpHealthCheck/WithHttpsHealthCheck. #6081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
davidfowl
reviewed
Oct 3, 2024
Co-authored-by: David Fowler <davidfowl@gmail.com>
davidfowl
reviewed
Oct 3, 2024
davidfowl
reviewed
Oct 3, 2024
davidfowl
reviewed
Oct 3, 2024
davidfowl
approved these changes
Oct 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-app-model
Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
area-integrations
Issues pertaining to Aspire Integrations packages
postgres
Issues related to Postgres integrations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
WithHttpHealthCheckandWithHttpsHealthCheck. This enables any resource that implementsIResourceWithEndpointsto quickly have a health check added to it so that it can paticipate in theWaitFor(...)API pattern (and show readiness status on the dashboard).Related #5645
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow