Skip to content

Conversation

@mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Oct 3, 2024

Description

This PR adds WithHttpHealthCheck and WithHttpsHealthCheck. This enables any resource that implements IResourceWithEndpoints to quickly have a health check added to it so that it can paticipate in the WaitFor(...) API pattern (and show readiness status on the dashboard).

Related #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@mitchdenny mitchdenny self-assigned this Oct 3, 2024
@mitchdenny mitchdenny added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication area-integrations Issues pertaining to Aspire Integrations packages postgres Issues related to Postgres integrations labels Oct 3, 2024
@mitchdenny mitchdenny added this to the 9.0 milestone Oct 3, 2024
Co-authored-by: David Fowler <davidfowl@gmail.com>
@mitchdenny mitchdenny enabled auto-merge (squash) October 3, 2024 09:19
@mitchdenny mitchdenny merged commit f2c016d into main Oct 3, 2024
9 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/with-http-healthcheck branch October 3, 2024 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication area-integrations Issues pertaining to Aspire Integrations packages postgres Issues related to Postgres integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants