Experimental custom domain support for ACA. #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
force-pushed
the
midenn/custom-domains
branch
2 times, most recently
from
efe5257
to
4158361
Compare
mitchdenny
changed the title
mitchdenny
force-pushed
the
midenn/custom-domains
branch
from
4158361
to
4359e24
Compare
davidfowl
reviewed
Oct 17, 2024
davidfowl
reviewed
Oct 17, 2024
mitchdenny
force-pushed
the
midenn/custom-domains
branch
from
4359e24
to
38e0998
Compare
davidfowl
approved these changes
Oct 18, 2024
mitchdenny
force-pushed
the
midenn/custom-domains
branch
from
38e0998
to
70bf98d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidfowl
reviewed
Oct 18, 2024
| throw new ArgumentException("Cannot configure custom domain when resource is not parented by ResourceModuleConstruct.", nameof(app)); | ||
| } | ||
|
|
||
| var containerAppManagedEnvironmentIdParameter = module.GetResources().OfType<ProvisioningParameter>().Single( |
mitchdenny
force-pushed
the
midenn/custom-domains
branch
from
70bf98d
to
e7b02d1
Compare
mitchdenny
force-pushed
the
midenn/custom-domains
branch
from
efeec27
to
c011637
Compare
mitchdenny
force-pushed
the
midenn/custom-domains
branch
from
a03ea7f
to
07b37a0
Compare
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11433206663 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds custom domain support to the playground sample. The approach used here is that you deploy first without custom domains enabled (just hit enter on the
certificateNamevalue but provide the desired custom domain name.Then once you've deployed for the first time go into the portal and go through the binding process for the custom domain and create the appropriate domain ownership verification steps (creating TXT/CNAME records etc).
Once the domain is up and running then you can deploy again, but this time edit the
config.jsonfile with the name of the certificate (look in the container app environment).Opening this as a PR for now for discussion since we'll probably want to wrap this up in some kind of API. The API would need to augment the callback for configuring the custom domains but also inject parameters for each project its applied to.
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow