Fix feed for daily builds from main branch #6472
Conversation
| @@ -28,6 +28,7 @@ If you use [Package Source Mapping](https://learn.microsoft.com/en-us/nuget/cons | |||
| <packageSource key="dotnet9"> | |||
| <package pattern="Aspire.*" /> | |||
| <package pattern="Microsoft.Extensions.ServiceDiscovery*" /> | |||
| <package pattern="Microsoft.Extensions.Http.Resilience" /> | |||
There was a problem hiding this comment.
Are we sure all the uses of this package in the repo are using a version that's from the dotnet9 feed? If some are using 8.0.10 still we'll need to include nuget.org and have a mapping for that too I think.
There was a problem hiding this comment.
In updating dotnet/aspire-samples to use dailies I'm finding I need a mapping for Microsoft.Extensions.Resilience too. Maybe we just make this Microsoft.Extensions.*?
There was a problem hiding this comment.
8.0.10 is out on nuget.org. Perhaps we should instead not try to guess and remove the package source mapping from our suggested nuget.config, as the actual one that the users end up using will be different depending on the things that their app is using.
There was a problem hiding this comment.
The way our instructions are now, we are only providing the mappings for the packages produced in this repo, but that is not a guarantee that you won't need more depending on your project.
There was a problem hiding this comment.
I think we should make it as clear as possible to help folks set their project up for the highest changes of success.
There was a problem hiding this comment.
Right, we need all feeds that the Aspire bits need. That includes non-released dependencies we're building against. Or are there none of those now?
There was a problem hiding this comment.
What's the blocker with this PR?
There was a problem hiding this comment.
I think it is just to make sure that the feeds are complete, but I just haven't had the chance to come back to this as it's been a bit hectic the last few days. If we want to merge as is, we could and I can send a follow-up later to address feedback, or otherwise I can take a look at this in a few days.
There was a problem hiding this comment.
yea lets its broken right now
github-actions
bot
added
the
area-codeflow
cc: @DamianEdwards
Microsoft Reviewers: Open in CodeFlow