Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filter buttons consistent between pages #6607

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 5, 2024

Description

  • Icon size is consistently 20px. The filter icon was too large on resources, and too small on logs/traces.
  • FIlter button is consistently to the right of the search box. Move icon on resources to the right.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK marked this pull request as ready for review November 5, 2024 13:10
@mitchdenny
Copy link
Member

Before (resources page filter):

image

After (resources page filter):

image

Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesNK JamesNK merged commit 7007cf6 into main Nov 7, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/filter-button-consistency branch November 7, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants