Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dashboard login URL log message last #6654

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 13, 2024

Description

While trying out the standalone dashboard I found that the log message with the login link was hard to find because it was mixed in the middle of other log messages.

This PR moves the login link to the last log message at startup.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@@ -36,7 +36,7 @@ public IEnumerable<string> GetUsers()
return null;
}

return JsonSerializer.Deserialize<CustomerBasket>(data!, s_jsonSerializerOptions);
return JsonSerializer.Deserialize<CustomerBasket>(data.ToString(), s_jsonSerializerOptions);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated to new VS and got a warning about ambigious overload here between span and string. I believe this is caused by work in the compiler to make span more first class.

Fixed by explicitly calling ToString instead of previously using implicitly string conversion.

@JamesNK JamesNK merged commit 8962f37 into main Nov 14, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/dashboard-login-url branch November 14, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants