Improve page titles by adding (resource) or (trace name) where appropriate. #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JamesNK
reviewed
Dec 30, 2024
| <PageTitle><ApplicationName ResourceName="@nameof(Dashboard.Resources.TraceDetail.TraceDetailPageTitle)" Loc="@Loc" /></PageTitle> | ||
| <PageTitle> | ||
| <ApplicationName | ||
| AdditionalText="@(_trace?.RootSpan?.Name)" |
There was a problem hiding this comment.
On line 32 there is a header displayed for the page. Move creating that title to a method and reuse here and there.
| <PageTitle><ApplicationName ResourceName="@nameof(Dashboard.Resources.Metrics.MetricsPageTitle)" Loc="@Loc" /></PageTitle> | ||
| <PageTitle> | ||
| <ApplicationName | ||
| AdditionalText="@PageViewModel.SelectedApplication.Id?.ReplicaSetName" |
There was a problem hiding this comment.
If there is also an instrumented selected then the additonal text can combine both
e.g. just app: frontend, instrumented selected: frontend - http.client.request.duration
| } | ||
|
|
||
| _pageTitle = AdditionalText is null |
There was a problem hiding this comment.
Suggested change
| _pageTitle = AdditionalText is null | |
| _pageTitle = string.IsNullOrEmpty(AdditionalText) |
JamesNK
reviewed
Dec 30, 2024
| @@ -12,6 +12,9 @@ public sealed partial class ApplicationName : ComponentBase, IDisposable | |||
| { | |||
| private CancellationTokenSource? _disposalCts; | |||
|
|
|||
| [Parameter] | |||
| public string? AdditionalText { get; init; } | |||
There was a problem hiding this comment.
The parameters in this control should be set, not init. Fix this one and the other parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates console log/traces/metrics/structured logs page titles to include the resource, replica set, or trace span name where set, to show more information.
Also renames
ApplicationNametoAspirePageTitlebecause the component allows for additional text alongside the application name.Fixes #5672
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):Microsoft Reviewers: Open in CodeFlow