Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sorting resource attributes in resource details, don't sort masked values #6975

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adamint
Copy link
Member

@adamint adamint commented Dec 20, 2024

Description

PropertyGrid by default sorts masked values, we shouldn't be doing that. I also enabled sorting in the resource attributes grid in resource details, as it's the only grid that doesn't allow sorting.

Fixes #6008

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

@adamint adamint requested a review from drewnoakes December 20, 2024 22:27
@JamesNK
Copy link
Member

JamesNK commented Dec 30, 2024

PropertyGrid by default sorts masked values, we shouldn't be doing that.

Why do you say this? The intention of masking values is to prevent accidently showing a secret when screensharing. I know that sorting can give some hints about the values (env1 is ordered before env2, and env2 starts with a g, so env1 starts with a character before g), but I don't think there is a real danger here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WebToolsE2E][Aspire] The attribute value column in the resource table does not support sorting yet.
2 participants