[CI] Test summary reporter improvements #9263
Conversation
github-actions
bot
added
the
area-integrations
radical
requested review from
RussKie,
danmoseley and
davidfowl
and removed request for
RussKie
There was a problem hiding this comment.
Pull Request Overview
This PR improves the test summary reporter by adding log artifact links, addressing Windows run issues, and increasing logging detail.
- Adds log artifact links in report headers
- Fixes Windows execution paths and logging
- Enhances error messaging and stdout logging for missing or empty test files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/GenerateTestSummary/TestSummaryGenerator.cs | Refactors report generation to include optional URL links and additional logging output for test failures |
| tools/GenerateTestSummary/Program.cs | Updates handling of input parameters and error messages; enforces combined summary option constraints |
| .github/workflows/run-tests.yml | Replaces shell command with PowerShell script ensuring Windows compatibility and proper command invocation |
Comments suppressed due to low confidence (1)
.github/workflows/run-tests.yml:306
- Consider verifying that the DOTNET_SCRIPT environment variable is defined and valid to avoid potential runtime issues on systems where the variable might not be set.
& ${{ env.DOTNET_SCRIPT }} run --project "${{ github.workspace }}/tools/GenerateTestSummary/GenerateTestSummary.csproj" -- "${{ github.workspace }}/testresults" -u "${{ steps.upload-logs.outputs.artifact-url }}"
Co-authored-by: Dan Moseley <danmose@microsoft.com>
| : "os?"; | ||
| : throw new InvalidOperationException($"Could not determine OS from file path: {filePath}"); | ||
|
|
||
| tableBuilder.AppendLine(CultureInfo.InvariantCulture, $"| {(failed > 0 ? "❌" : "✅")} [{os}] {GetTestTitle(filePath)} | {passed} | {failed} | {skipped} | {total} |"); |
There was a problem hiding this comment.
I noticed in my tests that even when there are not test results (i.e., all 0, can happen when the runner crashed) we show the "tick". It looks odd.
There was a problem hiding this comment.
Can you share an example of that, so I can fix accordingly?
There was a problem hiding this comment.
@ig-raiderler anything you'd do differently? we welcome improvements |
3 participants
Uh oh!
There was an error while loading. Please reload this page.