Skip to content

Conversation

adamint
Copy link
Member

@adamint adamint commented May 19, 2025

Description

Ensure that all columns have tooltips. Since we use AspireTemplateColumn/AspirePropertyColumn everywhere, we can just set this property. This issue was only affecting certain columns.

After:
image

Before:
image

(no tooltip)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings May 19, 2025 21:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that all grid columns display tooltips by updating the AspireTemplateColumn and AspirePropertyColumn components to set the Tooltip property to true during initialization.

  • Sets Tooltip = true in the OnInitialized() method for both column classes
  • Addresses the missing tooltip issue in specific grid columns

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/Aspire.Dashboard/Components/Controls/Grid/AspireTemplateColumn.cs Added OnInitialized override to set Tooltip = true
src/Aspire.Dashboard/Components/Controls/Grid/AspirePropertyColumn.cs Added OnInitialized override to set Tooltip = true

[Parameter]
public string? ColumnId { get; set; }

protected override void OnInitialized()
Copy link
Preview

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both AspireTemplateColumn and AspirePropertyColumn set Tooltip = true in their OnInitialized methods. Consider refactoring this shared behavior into a common base class to reduce duplicate code and ease future maintenance.

Copilot uses AI. Check for mistakes.

[Parameter]
public string? ColumnId { get; set; }

protected override void OnInitialized()
Copy link
Preview

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both AspireTemplateColumn and AspirePropertyColumn set Tooltip = true in their OnInitialized methods. Consider refactoring this shared behavior into a common base class to reduce duplicate code and ease future maintenance.

Copilot uses AI. Check for mistakes.

@danmoseley danmoseley enabled auto-merge (squash) May 19, 2025 21:51
@danmoseley danmoseley merged commit 2b7f531 into dotnet:main May 19, 2025
254 of 255 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants