Trace detail improvements #9443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the trace detail view by updating the header layout to better handle overflow and by correcting the resource counting logic to include peer resources.
- Updated CSS to support a grid layout for the trace header with overflow behavior.
- Adjusted the C# logic to compute the resource count from trace spans.
- Refactored the Razor view to incorporate the new header layout with enhanced display of trace information.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Dashboard/Components/Pages/TraceDetail.razor.css | Added grid styling and overflow support for trace header elements. |
| src/Aspire.Dashboard/Components/Pages/TraceDetail.razor.cs | Introduced _resourceCount and updated resource counting logic. |
| src/Aspire.Dashboard/Components/Pages/TraceDetail.razor | Refactored header layout to use FluentOverflow and display updated trace details. |
| <ToolbarSection> | ||
| <div class="toolbar-left"> | ||
| @Loc[nameof(Dashboard.Resources.TraceDetail.TraceDetailTraceStartHeader)] <strong title="@FormatHelpers.FormatDateTime(TimeProvider, _trace.FirstSpan.StartTime, MillisecondsDisplay.Full)">@FormatHelpers.FormatDateTime(TimeProvider, _trace.FirstSpan.StartTime, MillisecondsDisplay.Truncated)</strong> | ||
| <div slot class="trace-header"> |
There was a problem hiding this comment.
The 'slot' attribute is used without an explicit value. Please confirm whether a default slot is intended or if a specific slot name should be provided.
Member
|
dashboard changes should include screenshots 😄 |
Member
Author
|
The copilot button (not present here) adds more horizontal space. Overflowing the values is better than wrapping toolbar across two lines. |
davidfowl
approved these changes
May 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate