Skip to content

Commit

Permalink
Add comment to gRPC template tests SkipOnAlpine attribute (#46517)
Browse files Browse the repository at this point in the history
  • Loading branch information
JamesNK authored Feb 8, 2023
1 parent 9a6883f commit 287d7ea
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/ProjectTemplates/test/Templates.Tests/GrpcTemplateTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,31 +36,31 @@ public ITestOutputHelper Output

[ConditionalFact]
[SkipOnHelix("Not supported queues", Queues = "windows.11.arm64.open;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)]
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")]
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")] // protoc doesn't support Alpine. Note that the issue was closed with a workaround which isn't applied to our OS image.
public async Task GrpcTemplate()
{
await GrpcTemplateCore();
}

[ConditionalFact(Skip = "Unskip when there are no more build or publish warnings for native AOT.")]
[SkipOnHelix("Not supported queues", Queues = "windows.11.arm64.open;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)]
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")]
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")] // protoc doesn't support Alpine. Note that the issue was closed with a workaround which isn't applied to our OS image.
public async Task GrpcTemplateNativeAot()
{
await GrpcTemplateCore(args: new[] { ArgConstants.PublishNativeAot });
}

[ConditionalFact]
[SkipOnHelix("Not supported queues", Queues = "windows.11.arm64.open;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)]
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")]
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")] // protoc doesn't support Alpine. Note that the issue was closed with a workaround which isn't applied to our OS image.
public async Task GrpcTemplateProgramMain()
{
await GrpcTemplateCore(args: new[] { ArgConstants.UseProgramMain });
}

[ConditionalFact(Skip = "Unskip when there are no more build or publish warnings for native AOT.")]
[SkipOnHelix("Not supported queues", Queues = "windows.11.arm64.open;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)]
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")]
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")] // protoc doesn't support Alpine. Note that the issue was closed with a workaround which isn't applied to our OS image.
public async Task GrpcTemplateProgramMainNativeAot()
{
await GrpcTemplateCore(args: new[] { ArgConstants.UseProgramMain, ArgConstants.PublishNativeAot });
Expand Down

0 comments on commit 287d7ea

Please sign in to comment.