Remove existing implementation of StartupExceptionPage and use the on…

…e in Common

[Fixes #831] Fix startup exception page to handle flattened exceptions

src/Microsoft.AspNetCore.Hosting/Internal/WebHost.cs

@@ -5,16 +5,20 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
+using System.Reflection;
+using System.Runtime.InteropServices;
 using System.Threading;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Hosting.Builder;
 using Microsoft.AspNetCore.Hosting.Server;
 using Microsoft.AspNetCore.Hosting.Server.Features;
+using Microsoft.AspNetCore.Hosting.Views;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Http.Features;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.StackTrace.Sources;
 
 namespace Microsoft.AspNetCore.Hosting.Internal
 {
@@ -168,15 +172,44 @@ private RequestDelegate BuildApplication()
  // Generate an HTML error page.
  var hostingEnv = _applicationServices.GetRequiredService<IHostingEnvironment>();
  var showDetailedErrors = hostingEnv.IsDevelopment() || _options.DetailedErrors;
- var errorBytes = StartupExceptionPage.GenerateErrorHtml(showDetailedErrors, ex);
 
+ var model = new ErrorPageModel();
+ var runtimeType = Microsoft.Extensions.Internal.RuntimeEnvironment.RuntimeType;
+ model.RuntimeDisplayName = (runtimeType == "CoreCLR") ? ".NET Core" : runtimeType == "CLR" ? ".NET Framework" : "Mono";
+#if NETSTANDARD1_3
+ var systemRuntimeAssembly = typeof(System.ComponentModel.DefaultValueAttribute).GetTypeInfo().Assembly;
+ var assemblyVersion = new AssemblyName(systemRuntimeAssembly.FullName).Version.ToString();
+ var clrVersion = assemblyVersion;
+#else
+ var clrVersion = Environment.Version.ToString();
+#endif
+ model.RuntimeArchitecture = RuntimeInformation.ProcessArchitecture.ToString();
+ var currentAssembly = typeof(ErrorPage).GetTypeInfo().Assembly;
+ model.CurrentAssemblyVesion = currentAssembly
+ .GetCustomAttribute<AssemblyInformationalVersionAttribute>()
+ .InformationalVersion;
+ model.ClrVersion = clrVersion;
+ model.OperatingSystemDescription = RuntimeInformation.OSDescription;
+
+ if (showDetailedErrors)
+ {
+ var exceptionDetailProvider = new ExceptionDetailsProvider(
+ hostingEnv.ContentRootFileProvider,
+ sourceCodeLineCount: 6);
+
+ model.ErrorDetails = exceptionDetailProvider.GetDetails(ex);
+ }
+ else
+ {
+ model.ErrorDetails = new ExceptionDetails[0];
+ }
+
+ var errorPage = new ErrorPage(model);
  return context =>
  {
  context.Response.StatusCode = 500;
- context.Response.Headers["Cache-Control"] = "private, max-age=0";
- context.Response.ContentType = "text/html; charset=utf-8";
- context.Response.ContentLength = errorBytes.Length;
- return context.Response.Body.WriteAsync(errorBytes, 0, errorBytes.Length);
+ context.Response.Headers["Cache-Control"] = "no-cache";
+ return errorPage.ExecuteAsync(context);
  };
  }
  }

src/Microsoft.AspNetCore.Hosting/Resources.resx

@@ -0,0 +1,129 @@
+<?xml version="1.0" encoding="utf-8"?>
+<root>
+ <!-- 
+ Microsoft ResX Schema 
+ 
+ Version 2.0
+ 
+ The primary goals of this format is to allow a simple XML format 
+ that is mostly human readable. The generation and parsing of the 
+ various data types are done through the TypeConverter classes 
+ associated with the data types.
+ 
+ Example:
+ 
+ ... ado.net/XML headers & schema ...
+ <resheader name="resmimetype">text/microsoft-resx</resheader>
+ <resheader name="version">2.0</resheader>
+ <resheader name="reader">System.Resources.ResXResourceReader, System.Windows.Forms, ...</resheader>
+ <resheader name="writer">System.Resources.ResXResourceWriter, System.Windows.Forms, ...</resheader>
+ <data name="Name1"><value>this is my long string</value><comment>this is a comment</comment></data>
+ <data name="Color1" type="System.Drawing.Color, System.Drawing">Blue</data>
+ <data name="Bitmap1" mimetype="application/x-microsoft.net.object.binary.base64">
+ <value>[base64 mime encoded serialized .NET Framework object]</value>
+ </data>
+ <data name="Icon1" type="System.Drawing.Icon, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
+ <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
+ <comment>This is a comment</comment>
+ </data>
+ 
+ There are any number of "resheader" rows that contain simple 
+ name/value pairs.
+ 
+ Each data row contains a name, and value. The row also contains a 
+ type or mimetype. Type corresponds to a .NET class that support 
+ text/value conversion through the TypeConverter architecture. 
+ Classes that don't support this are serialized and stored with the 
+ mimetype set.
+ 
+ The mimetype is used for serialized objects, and tells the 
+ ResXResourceReader how to depersist the object. This is currently not 
+ extensible. For a given mimetype the value must be set accordingly:
+ 
+ Note - application/x-microsoft.net.object.binary.base64 is the format 
+ that the ResXResourceWriter will generate, however the reader can 
+ read any of the formats listed below.
+ 
+ mimetype: application/x-microsoft.net.object.binary.base64
+ value : The object must be serialized with 
+ : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
+ : and then encoded with base64 encoding.
+ 
+ mimetype: application/x-microsoft.net.object.soap.base64
+ value : The object must be serialized with 
+ : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
+ : and then encoded with base64 encoding.
+
+ mimetype: application/x-microsoft.net.object.bytearray.base64
+ value : The object must be serialized into a byte array 
+ : using a System.ComponentModel.TypeConverter
+ : and then encoded with base64 encoding.
+ -->
+ <xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
+ <xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
+ <xsd:element name="root" msdata:IsDataSet="true">
+ <xsd:complexType>
+ <xsd:choice maxOccurs="unbounded">
+ <xsd:element name="metadata">
+ <xsd:complexType>
+ <xsd:sequence>
+ <xsd:element name="value" type="xsd:string" minOccurs="0" />
+ </xsd:sequence>
+ <xsd:attribute name="name" use="required" type="xsd:string" />
+ <xsd:attribute name="type" type="xsd:string" />
+ <xsd:attribute name="mimetype" type="xsd:string" />
+ <xsd:attribute ref="xml:space" />
+ </xsd:complexType>
+ </xsd:element>
+ <xsd:element name="assembly">
+ <xsd:complexType>
+ <xsd:attribute name="alias" type="xsd:string" />
+ <xsd:attribute name="name" type="xsd:string" />
+ </xsd:complexType>
+ </xsd:element>
+ <xsd:element name="data">
+ <xsd:complexType>
+ <xsd:sequence>
+ <xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
+ <xsd:element name="comment" type="xsd:string" minOccurs="0" msdata:Ordinal="2" />
+ </xsd:sequence>
+ <xsd:attribute name="name" type="xsd:string" use="required" msdata:Ordinal="1" />
+ <xsd:attribute name="type" type="xsd:string" msdata:Ordinal="3" />
+ <xsd:attribute name="mimetype" type="xsd:string" msdata:Ordinal="4" />
+ <xsd:attribute ref="xml:space" />
+ </xsd:complexType>
+ </xsd:element>
+ <xsd:element name="resheader">
+ <xsd:complexType>
+ <xsd:sequence>
+ <xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
+ </xsd:sequence>
+ <xsd:attribute name="name" type="xsd:string" use="required" />
+ </xsd:complexType>
+ </xsd:element>
+ </xsd:choice>
+ </xsd:complexType>
+ </xsd:element>
+ </xsd:schema>
+ <resheader name="resmimetype">
+ <value>text/microsoft-resx</value>
+ </resheader>
+ <resheader name="version">
+ <value>2.0</value>
+ </resheader>
+ <resheader name="reader">
+ <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+ </resheader>
+ <resheader name="writer">
+ <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+ </resheader>
+ <data name="ErrorPageHtml_Title" xml:space="preserve">
+ <value>Internal Server Error</value>
+ </data>
+ <data name="ErrorPageHtml_UnhandledException" xml:space="preserve">
+ <value>An error occurred while starting the application.</value>
+ </data>
+ <data name="ErrorPageHtml_UnknownLocation" xml:space="preserve">
+ <value>Unknown location</value>
+ </data>
+</root>