Skip to content

Commit

Permalink
Fix generated namespaces
Browse files Browse the repository at this point in the history
  • Loading branch information
Nate McMaster committed Jan 15, 2019
1 parent 94f253f commit 91de195
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
7 changes: 0 additions & 7 deletions src/Components/Blazor/perf/Directory.Build.props

This file was deleted.

1 change: 1 addition & 0 deletions src/Components/Blazor/perf/Startup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using Microsoft.AspNetCore.Components.Builder;
using Microsoft.Extensions.DependencyInjection;
using perf;

namespace Microsoft.AspNetCore.Blazor.E2EPerformance
{
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Blazor/perf/_ViewImports.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
@using Microsoft.AspNetCore.Components.Routing
@using Microsoft.JSInterop
@using Microsoft.AspNetCore.Blazor.E2EPerformance
@using Microsoft.AspNetCore.Blazor.E2EPerformance.Shared
@using perf.Shared

This comment has been minimized.

Copy link
@SteveSandersonMS

SteveSandersonMS Jan 15, 2019

Member

Can we not do this? I understand this might just be one step trying to move towards getting it to build, but I'd be extremely keen not to have bizarre namespaces in the code!

This comment has been minimized.

Copy link
@natemcmaster

natemcmaster Jan 15, 2019

Contributor

@pranavkm how do I get Razor to use RootNamespace instead of the project folder name?

@SteveSandersonMS the motivation for the change is to avoid max_path issues. I don't have an alternative solution for max_path. I do have a solution for quirky names (which is 🙈 for now and get Razor to fix it.)

This comment has been minimized.

Copy link
@rynowak

rynowak Jan 16, 2019

Member
@namespace Microsoft.AspNetCore.Blazor.E2EPerformance

If this app has a _ViewImports.cshtml put it in there - namespaces will be computed related to that file.

This comment has been minimized.

Copy link
@SteveSandersonMS

SteveSandersonMS Jan 16, 2019

Member

Oh, cool!

0 comments on commit 91de195

Please sign in to comment.