PR feedback

dotnet · Jul 30, 2024 · eff6c7e · eff6c7e
1 parent 0d61918
commit eff6c7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Shared/Diagnostics/ActivityCreator.cs b/src/Shared/Diagnostics/ActivityCreator.cs
@@ -58,8 +58,8 @@ internal static class ActivityCreator
                 // Can only happen if there is a race between HasListeners and CreateActivity calls,
                 // and someone removing the listener.
                 //
-                // The only negative of calling the propagator twice is a small performance hit, but
-                // it's small and unlikely so it's not worth trying to optimize.
+                // The only negative of calling the propagator twice is a small performance hit.
+                // It's small and unlikely so it's not worth trying to optimize.
                 propagator.ExtractTraceIdAndState(
                     distributedContextCarrier,
                     propagatorGetter,

diff --git a/src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.cs b/src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.cs
@@ -857,11 +857,11 @@ public override IReadOnlyList<Type> GetParameterTypes(string methodName)
         ];
         IEnumerable<ActivityLink>? links = (linkedActivity is not null) ? [new ActivityLink(linkedActivity.Context)] : null;
 
-        var propagator = serviceProvider.GetService<DistributedContextPropagator>() ?? DistributedContextPropagator.Current;
-
         Activity? activity;
         if (headers != null)
         {
+            var propagator = serviceProvider.GetService<DistributedContextPropagator>() ?? DistributedContextPropagator.Current;
+
             activity = ActivityCreator.CreateFromRemote(
                 activitySource,
                 propagator,