Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate .nupkg files that contain aspnetcore-runtime MSI for insertion into Visual Studio #11071

Closed
natemcmaster opened this issue Jun 11, 2019 · 4 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Milestone

Comments

@natemcmaster
Copy link
Contributor

natemcmaster commented Jun 11, 2019

We are working with the SDK team to simplifying the insertion of the .NET Core SDK into Visual Studio. dotnet/installer#2166 Today, the ASP.NET Core runtime is inserted into VS via the .NET Core SDK. As a part of breaking the SDK into smaller pieces, we need to add a new build step to 2.1/2.2 and 3.0 builds which produce the following NuGet packages.

  • AspNetCore.SharedFramework.$(Arch).$(MajorVersion).$(MinorVersion)
    • ID = VS.Redist.Common.AspNetCore.SharedFramework.$(Arch).$(MajorVersion).$(MinorVersion)
    • Contents
      • $pkgRoot/aspnetcore-runtime-$(version)-win-$(Arch).msi
      • $pkgRoot/sfx_$(Arch).cab
    • Versions:
      • 2.1
      • 2.2
      • 3.0
    • Arch
      • x86
      • x64
  • AspNetCore.TargetingPack.$(Arch).$(MajorVersion).$(MinorVersion)
    • ID = VS.Redist.Common.AspNetCore.TargetingPack.$(Arch).$(MajorVersion).$(MinorVersion)
    • Contents
      • $pkgRoot/aspnetcore-targetingpack-$(version)-win-$(Arch).msi
    • Versions:
      • 3.0
    • Arch
      • x86
      • x64

Implementation suggestions

The simplest implementation can use nuget.exe and a .nuspec file to wrap the files in a nupkg. We don't need to code-sign the nupkg or ship it to nuget.org

Example: https://github.com/dotnet/core-sdk/blob/844978f4c2a042abf5fc924729466a4dce3c047d/src/redist/targets/packaging/windows/clisdk/VS.Redist.Common.NetCore.Toolset.nuspec

/cc @mmitche @johnbeisner

@natemcmaster natemcmaster added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 11, 2019
@natemcmaster natemcmaster added this to the 2.1.12 milestone Jun 11, 2019
@natemcmaster
Copy link
Contributor Author

@johnbeisner can you confirm the IDs and layout of files in the nupkg in the description above 👆?

@natemcmaster natemcmaster changed the title 2.x servicing - generate .nupkg files that contain aspnetcore-runtime MSI for insertion into Visual Studio Generate .nupkg files that contain aspnetcore-runtime MSI for insertion into Visual Studio Jun 11, 2019
@natemcmaster
Copy link
Contributor Author

Confirmed over email and updated the description above. Package ID should include major.minor, example VS.Redist.Common.AspNetCore.SharedFramework.x64.2.1

@natemcmaster
Copy link
Contributor Author

cc @Pilchie - would be good to have someone from @anurse's team help out here. @johnbeisner has manually crafted the first round of .nupkgs to bootstrap the changes in VS, but we should add this to our build outputs soon so he doesn't have to keep doing that.

@jkotalik
Copy link
Contributor

This should be done in 2.1, will merge into 2.2. Closing for now

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

No branches or pull requests

2 participants