Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Identity migrations to 3.0 #12168

Closed
ajcvickers opened this issue Jul 14, 2019 · 2 comments
Closed

Update Identity migrations to 3.0 #12168

ajcvickers opened this issue Jul 14, 2019 · 2 comments
Assignees
@HaoK
Labels
area-identity Includes: Identity and providers Done This issue has been fixed
Milestone
3.0.0-preview8

Comments

@ajcvickers
Copy link
Member

Currently the project templates still contain migrations generated for 2.2. They should be updated to migrations generated for 3.0.

/cc @HaoK @blowdart
@ajcvickers ajcvickers added this to the 3.0.0-preview8 milestone Jul 14, 2019
@ajcvickers
Copy link
Member Author

@HaoK @blowdart Putting this in preview 8.

ajcvickers added a commit to dotnet/efcore that referenced this issue Jul 14, 2019
@ajcvickers
Add more MusicStore and Identity tests
53c3500 
Covering all the queries MusicStore does, and also updating the tests to properly use store-generated values.

Also, added the ModelSnapshots generated by the project templates for 2.1, 2.2, and 3.0, for SQL Server and SQLite. They all diff correctly against the current code showing no differences in the generated schema.

Part of #15662 and #11838

Note that currently the ASP.NET 3.0 templates still contain migrations generated by 2.2. See dotnet/aspnetcore#12168
@ajcvickers ajcvickers mentioned this issue Jul 14, 2019
Merged
@HaoK HaoK added the area-identity Includes: Identity and providers label Jul 14, 2019
ajcvickers added a commit to dotnet/efcore that referenced this issue Jul 15, 2019
@ajcvickers
Add more MusicStore and Identity tests
865b861 
Covering all the queries MusicStore does, and also updating the tests to properly use store-generated values.

Also, added the ModelSnapshots generated by the project templates for 2.1, 2.2, and 3.0, for SQL Server and SQLite. They all diff correctly against the current code showing no differences in the generated schema.

Part of #15662 and #11838

Note that currently the ASP.NET 3.0 templates still contain migrations generated by 2.2. See dotnet/aspnetcore#12168
ajcvickers added a commit to dotnet/efcore that referenced this issue Jul 15, 2019
@ajcvickers
Add more MusicStore and Identity tests
dbf76eb 
Covering all the queries MusicStore does, and also updating the tests to properly use store-generated values.

Also, added the ModelSnapshots generated by the project templates for 2.1, 2.2, and 3.0, for SQL Server and SQLite. They all diff correctly against the current code showing no differences in the generated schema.

Part of #15662 and #11838

Note that currently the ASP.NET 3.0 templates still contain migrations generated by 2.2. See dotnet/aspnetcore#12168
@HaoK
Copy link
Member

HaoK commented Jul 16, 2019 •
edited
Loading

For posterity since it took me forever to find the batch file I used to generate this last time: https://github.com/aspnet/AspNetCore/tree/master/src/ProjectTemplates/migrations

@HaoK HaoK mentioned this issue Jul 17, 2019
Merged
@ajcvickers ajcvickers mentioned this issue Jul 19, 2019
Closed
@HaoK HaoK added the Done This issue has been fixed label Jul 19, 2019
@HaoK HaoK closed this as completed Jul 19, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
area-identity Includes: Identity and providers Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview8
Development

No branches or pull requests
2 participants
@ajcvickers @HaoK