Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change [Parameter] warning (BL0004) to be an error - Non-public parameters #12294

Closed
NTaylorMullen opened this issue Jul 17, 2019 · 1 comment
Closed

Change [Parameter] warning (BL0004) to be an error - Non-public parameters #12294

NTaylorMullen opened this issue Jul 17, 2019 · 1 comment
Assignees
@NTaylorMullen
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Milestone
3.0.0-preview9

Comments

@NTaylorMullen
Copy link
Contributor

In preview8 we added a warning for non-public [Parameter]s. In preview9 we need to make this an error.

This is tracking work initially mentioned here.
@NTaylorMullen NTaylorMullen added enhancement This issue represents an ask for new feature or an enhancement to an existing one PRI: 1 - Required area-blazor Includes: Blazor, Razor Components labels Jul 17, 2019
@NTaylorMullen NTaylorMullen added this to the 3.0.0-preview9 milestone Jul 17, 2019
@NTaylorMullen NTaylorMullen self-assigned this Jul 17, 2019
@rynowak rynowak mentioned this issue Jul 17, 2019
Closed
10 tasks
@NTaylorMullen NTaylorMullen mentioned this issue Jul 17, 2019
Closed
@Joe4evr
Copy link

Joe4evr commented Jul 18, 2019

Just to note, there are apparently people who want to have internal [Parameter]s: #12271.

NTaylorMullen added a commit that referenced this issue Jul 31, 2019
@NTaylorMullen
Change non-public [Parameter] warning severities to error.
2ef9de7 
- In preview8 we warned users for non-public `[Parameter]`s and `[Parameter]` setters. For preview9 this is now an error because things will not work as they expect.
- Updated existing tests to reflect the new error expectation.

#12294
@NTaylorMullen NTaylorMullen mentioned this issue Jul 31, 2019
Merged
@Joe4evr Joe4evr mentioned this issue Aug 2, 2019
Closed
NTaylorMullen added a commit that referenced this issue Aug 2, 2019
@NTaylorMullen
Change non-public [Parameter] warning severities to error.
cb45919 
- In preview8 we warned users for non-public `[Parameter]`s and `[Parameter]` setters. For preview9 this is now an error because things will not work as they expect.
- Updated existing tests to reflect the new error expectation.

#12294
NTaylorMullen added a commit that referenced this issue Aug 2, 2019
@NTaylorMullen
Change non-public [Parameter] warning severities to error.
d312d79 
- In preview8 we warned users for non-public `[Parameter]`s and `[Parameter]` setters. For preview9 this is now an error because things will not work as they expect.
- Updated existing tests to reflect the new error expectation.

#12294
@NTaylorMullen NTaylorMullen added Done This issue has been fixed and removed Working labels Aug 2, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Milestone
3.0.0-preview9
Development

No branches or pull requests
2 participants
@Joe4evr @NTaylorMullen