Skip to content

Consider making the targets in Razor.RuntimeCompilation be transitive #12768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pranavkm opened this issue Jul 31, 2019 · 0 comments
Closed

Consider making the targets in Razor.RuntimeCompilation be transitive #12768

pranavkm opened this issue Jul 31, 2019 · 0 comments
Assignees
@pranavkm
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.1.0-preview2

Comments

@pranavkm
Copy link
Contributor

The RuntimeCompilation targets sets up the application to preserve compilation context \ ref assemblies. Consider a P2P scenario such as integration testing where

a) The Web project references the package and requires runtime compilation
b) The test project references the Web project

In this case, PreserveCompilationReferences is never set on the test project and runtime compilation will fail.

Workarounds include setting PreserveCompilationReferences in the test project or explicitly referencing the package in the test project.
@pranavkm pranavkm mentioned this issue Jul 31, 2019
Closed
@mkArtakMSFT mkArtakMSFT added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 31, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.1.0 milestone Jul 31, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.1.0, Backlog Jul 31, 2019
@pranavkm pranavkm mentioned this issue Sep 28, 2019
Closed
@pranavkm pranavkm removed this from the Backlog milestone Sep 28, 2019
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Sep 30, 2019
@mkArtakMSFT mkArtakMSFT added this to the 5.0.0-preview1 milestone Sep 30, 2019
@pranavkm pranavkm mentioned this issue Oct 9, 2019
Closed
pranavkm added a commit that referenced this issue Oct 9, 2019
@pranavkm
Ensure Microsoft.AspNetCore.Razor.RuntimeCompilation has the right bu…
6aaf694 
…ild targets

* Include build and build transitive folders in RuntimeCompilation package
* Use a different folder name to allow GitHub indexing. See #14846
* Add a test to verify transitive build targets work

Fixes #14813
Fixes #12768
@pranavkm pranavkm mentioned this issue Oct 9, 2019
Merged
pranavkm added a commit that referenced this issue Oct 11, 2019
@pranavkm
Ensure Microsoft.AspNetCore.Razor.RuntimeCompilation has the right bu…
6dee2f5 
…ild targets (#14863)

* Include build and build transitive folders in RuntimeCompilation package
* Use a different folder name to allow GitHub indexing. See #14846
* Add a test to verify transitive build targets work

Fixes #14813
Fixes #12768
@pranavkm pranavkm added the Done This issue has been fixed label Oct 11, 2019
@pranavkm pranavkm mentioned this issue Oct 16, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.1.0-preview2
Development

No branches or pull requests
2 participants
@pranavkm @mkArtakMSFT